Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

different virutal-service may refer to the same address，when the addr… #529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

different virutal-service may refer to the same address，when the addr… #529

wants to merge 1 commit into from
+168 −1

Conversation

weiyanhua100
Copy link
Contributor

…ess is operated by the script specified by quorum_own var, Add judgment of other virtual-service's quorum_state that refer the same address.

@ywc689 ywc689 requested a review from ytwang0320 March 3, 2020 09:18
@ywc689 ywc689 added the pr/to-confirm-needs consider whether the feature of pr is needed label Jul 16, 2020
@ywc689 ywc689 requested a review from azura27 September 9, 2020 01:20
@azura27
Copy link
Collaborator

azura27 commented Sep 14, 2020 •
edited
Loading

@weiyanhua100 Hello, as the struct virtual_server_t no longer has membe: addr_ip, I has test after deleting the param below:
/* visit addr_ip list */
l = vsg->addr_ip;
for (e = LIST_HEAD(l); e; ELEMENT_NEXT(e)) {
vsg_entry = ELEMENT_DATA(e);
ret |= vs_addr_cmp(addr, &vsg_entry->addr);
}
The code works OK without this param

@azura27 azura27 added the pr/codes-need-change problems found in the line-by-line code review and need to be fixed label Sep 14, 2020
@weiyanhua100
Copy link
Contributor Author

@weiyanhua100 Hello, as the struct virtual_server_t no longer has membe: addr_ip, I has test after deleting the param below:
/* visit addr_ip list */
l = vsg->addr_ip;
for (e = LIST_HEAD(l); e; ELEMENT_NEXT(e)) {
vsg_entry = ELEMENT_DATA(e);
ret |= vs_addr_cmp(addr, &vsg_entry->addr);
}
The code works OK without this param

Has been removed and resubmitted，thx.

different virutal-service may refer to the same address，when the addr…
caaddf9 
…ess is operated by the script specified by quorum_own var, Add judgment of other virtual-service's quorum_state that refer the same address.
@ywc689 ywc689 removed the pr/codes-need-change problems found in the line-by-line code review and need to be fixed label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywc689 ywc689 ywc689 left review comments

@ytwang0320 ytwang0320 Awaiting requested review from ytwang0320

@azura27 azura27 Awaiting requested review from azura27

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
pr/to-confirm-needs consider whether the feature of pr is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyanhua100 @azura27 @ywc689